Wireshark-dev: Re: [Wireshark-dev] New feature: custom columns
From: Stephen Fisher <[email protected]>
Date: Sun, 24 Feb 2008 15:34:47 -0700
On Fri, Feb 22, 2008 at 09:49:39PM -0500, Maynard, Chris wrote:

> I would prefer to keep the custom columns for 0.99.8, even if not 
> fully completed.  If it remains undocumented, then I doubt most people 
> outside of those reading this list will even know it's there, and most 
> people who do know it's there will be aware that there may be some 
> deficiencies, but I think it's going to prove useful enough that it 
> should remain.

Okay, we will leave them and hope no one finds it accidently and gets 
hung up on it :).  They can always come here or to -users and ask for 
help.

> In a prior e-mail, I suggested alphabetizing the column choices.  The 
> attached patch does just that.  Unfortunately, I had to run distclean 
> after the changes; otherwise the columns are all messed up.  The patch 
> involved re-ordering the dlist[] array in column.c so that the text 
> was alphabetical, then re-ordering the slist[] array above it, as well 
> as the enums in column_info.h to match.  To make it easier for myself, 
> I numbered both dlist[] and slist[] (in comments) before I started, 
> then re-arranged the dlist[].  Afterwards, I re-arranged slist[] so 
> the now out-of-order numbers matched and finally did the same for the 
> enums.  Finally, I re-numbered them all sequentially and added notes 
> about trying to keep them alphabetized.

Interesting idea.  Do you have a patch handy for your work that we could 
review for inclusion in the next version?


Thanks,
  Steve