I would prefer to keep the custom columns for 0.99.8, even if not fully completed. If it remains undocumented, then I doubt most people outside of those reading this list will even know it's there, and most people who do know it's there will be aware that there may be some deficiencies, but I think it's going to prove useful enough that it should remain.
In a prior e-mail, I suggested alphabetizing the column choices. The attached patch does just that. Unfortunately, I had to run distclean after the changes; otherwise the columns are all messed up. The patch involved re-ordering the dlist[] array in column.c so that the text was alphabetical, then re-ordering the slist[] array above it, as well as the enums in column_info.h to match. To make it easier for myself, I numbered both dlist[] and slist[] (in comments) before I started, then re-arranged the dlist[]. Afterwards, I re-arranged slist[] so the now out-of-order numbers matched and finally did the same for the enums. Finally, I re-numbered them all sequentially and added notes about trying to keep them alphabetized.
BTW: I added a new column, "Proto2" of type "Protocol", so that there were now 2 of them. After hitting "OK", then going back into "Edit -> Preferences -> Columns", I saw this: "Proto2 Protocol ()". Note the empty parenthesis. I changed it from "Proto2" to "Custom", and named it "TTL" with a field of "ip.ttl" and again hit "OK". Going back to the columns again, I saw this: "TTL Custom (ip.ttl)". Ah, so now I know what the parenthesis is supposed to be for - for specifying the custom field to use. To confirm, I changed the field name back to "Proto2" and selected "Protocol" again. Another "OK" and return to the column choices showed this strange setting: "Proto2 Protocol (ip.ttl)". So it seems that the parenthesis are mistakenly being displayed for all columns instead of for only the Custom column.
- Chris
1 attachment: column.patch: Contains a patch for 2 files, namely epan/column.c and epan/column_info.h, which alphabetizes the column choices.
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Stephen Fisher
Sent: Friday, February 22, 2008 8:25 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] New feature: custom columns
On Fri, Feb 22, 2008 at 11:41:31PM +0100, Stig Bjørlykke wrote:
> When having a custom column the "Apply as Filter" and "Prepare a
> Filter" does not work as expected in the Packet List. Sometimes
> nothing is selected, sometimes "frame.number == 1" is added to the
> Filter and sometimes the selection is invalid. I haven't found a
> pattern yet.
>
> You should have a look at this for 0.99.8 :)
Thanks, I'll look into this.. I'm wondering if we should just disable
the custom columns in 0.99.8 though since there is so much new work
going into it currently and more to come. I'm not comfortable moving
all of our improvements into 0.99.8pre2/0.99.8 without more testing
given 0.99.8 is coming out in a few days. The feature hasn't been
documented yet either (since it's not complete), but that won't take
long.
Steve
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev
-----------------------------------------
This email may contain confidential and privileged material for the
sole use of the intended recipient(s). Any review, use, retention,
distribution or disclosure by others is strictly prohibited. If you
are not the intended recipient (or authorized to receive for the
recipient), please contact the sender by reply email and delete all
copies of this message. Also, email is susceptible to data
corruption, interception, tampering, unauthorized amendment and
viruses. We only send and receive emails on the basis that we are
not liable for any such corruption, interception, tampering,
amendment or viruses or any consequence thereof.
Attachment:
column.patch
Description: column.patch
