Hi,
Note that this is only affecting SIP-T.
With the present code a line in the GUI containing a SIP/application/isup would look like :
13 0.302286 10.28.2.11 10.28.1.11 SIP/ISUP Status: 183 Session Progress, ISUP:reserved
Without "ISUP" it'd look :
13 0.302286 10.28.2.11 10.28.1.11 SIP/ISUP Status: 183 Session Progress, reserved
I thought with the former it was clearer that "reserved" belonged to the ISUP dissection rather than to SIP.
But feel free to change it if you like, I have no strong preferenses either way.
Best regards
Anders
-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of Jeff Morriss
Sent: den 5 april 2004 21:15
To: Ethereal development
Subject: Re: [Ethereal-dev] Changes for sip-t decoding
Anders Broman wrote:
> Checked in the changes to packet-isup.c with the change to put "ISUP:" in
> front off the ISUP message type.
Hmmm, is this necessary? Or could it be made a preference (like
'isup_show_cic_in_info')?
I generally prefer the Info column to be cleaner (since when viewing
ISUP over MTP3 or M3UA putting "ISUP:" in the Info column is
redundant--you can see the protocol in the Protocol column).
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev
