Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6363] proto: Add support for signed types in _proto_tree_add_bits_ret_val

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6363

--- Comment #1 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2011-09-20 03:57:11 PDT ---
+        if (value & (1ULL << (no_of_bits-1)))
>From README.developer

1.1.1 Portability.
:
When specifying an integral constant that doesn't fit in 32 bits, don't
use "LL" at the end of the constant - not all compilers use "LL" for
that.  Instead, put the constant in a call to the "G_GINT64_CONSTANT()"
macro, e.g.

    G_GINT64_CONSTANT(11644473600U)

rather than

    11644473600ULL
:

Should that be 
+        if (value & (G_GINT64_CONSTANT(1) << (no_of_bits-1)))
Then?
/Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.