Wireshark-bugs: [Wireshark-bugs] [Bug 6363] New: proto: Add support for signed types in _proto_tree_add_bits_ret_val

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 20 Sep 2011 02:55:16 -0700 (PDT)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6363

           Summary: proto: Add support for signed types in
                    _proto_tree_add_bits_ret_val
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: 246tnt@xxxxxxxxx


Created an attachment (id=7053)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7053)
Implementation of the feature

Build Information:
wireshark 1.7.0

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.4, with Cairo 1.10.2, with Pango 1.28.4, with
GLib 2.28.8, with libpcap 1.1.1, with libz 1.2.5, with POSIX capabilities
(Linux), with threads support, without SMI, without c-ares, without ADNS, with
Lua 5.1, with Python 2.7.1, with GnuTLS 2.10.5, with Gcrypt 1.4.6, without
Kerberos, without GeoIP, without PortAudio, without AirPcap.

Running on Linux 2.6.38-gentoo-r6, without locale, with libpcap version 1.1.1,
with libz 1.2.5, GnuTLS 2.10.5, Gcrypt 1.4.6.

Built using gcc 4.4.5.

--
proto: Add support for signed types in _proto_tree_add_bits_ret_val

Just because it's some bits extracted from a byte string doesn't mean
they can't be 2's complement signed values.

We sign extend them is the field is marked as signed.

Signed-off-by: Sylvain Munaut <tnt@xxxxxxxxxx>

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.