Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6363] proto: Add support for signed types in _proto_tree_add_bits_ret_val

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6363

--- Comment #2 from Sylvain Munaut <246tnt@xxxxxxxxx> 2011-09-20 04:20:10 PDT ---

> Should that be 
> +        if (value & (G_GINT64_CONSTANT(1) << (no_of_bits-1)))
> Then?
> /Anders

Yes, and G_GINT64_CONSTANT(-1) just below that as well.

Uploading a new patch now

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.