Wireshark · Ethereal-dev: Re: [Ethereal-dev] Patches for MingW

[Guy Harris <guy@xxxxxxxxxxxx>]

On Monday, August 18, 2003, at 11:16 AM, Gisle Vanem wrote:

> I've built all programs with MingW + gcc 3.3.1 (using the todays 
> snapshot).

Does "README.win32" need to be updated to give any instructions on 
doing so?

> Some patches where needed though:
>
> * <ws2tcpip.h> is needed for INET6 code in epan/resolv.c

Checked in.  (Would that also be needed for other compilers/platforms, 
e.g. VC++ 6.0?)

> * MingW already have 'rint()' in <math.h> and
>   'mode_t' in <sys/types.h>

Checked in.

> * In dftest.c I'm not sure about the 2nd and 5th arg. I
>  placed NULL to make it compile and run.

I checked in the correct fix (dftest isn't built by default, and I 
didn't configure it in the build, so I missed that when I added the new 
errno arguments to "read_prefs()" - I changed it to add new variables 
and report both open and read errors, as was done with Ethereal and 
Tethereal).