Wireshark-dev: Re: [Wireshark-dev] "PD" Column in Gerrit
From: Alexis La Goutte <[email protected]>
Date: Mon, 4 Aug 2014 14:06:39 +0200
On Mon, Aug 4, 2014 at 1:12 PM, Evan Huus <[email protected]> wrote:
> On Mon, Aug 4, 2014 at 5:26 AM, Graham Bloice <[email protected]>
> wrote:
>>
>> On 4 August 2014 07:34, Alexis La Goutte <[email protected]>
>> wrote:
>>>
>>> Hi Evan,
>>> On Mon, Aug 4, 2014 at 5:08 AM, Evan Huus <[email protected]> wrote:
>>> > Gerrit currently displays the status of the Petri-Dish flag in the
>>> > change-summary list as a "PD" column. I don't think it's particularly
>>> > useful, and it makes it harder to tell at a glance whether a change has
>>> > been
>>> > verified or not (since the two columns are right next to each other so
>>> > you
>>> > can't as easily scan for the green checkmark).
>>> >
>>> > Does anybody else prefer to keep it shown? Is there even a way to
>>> > remove it
>>> > (I looked in preferences but didn't see anything).
>>> >
>>> > Thoughts?
>>> +1 but i not sure if it is possible...
>>>
>>>
>>
>> I find it useful, although when I find a self+2 commit that breaks the
>> build without the PD flag it makes me want to rant.
>
>
> On that topic, Alexis (and/or Gerald) the petri-dish seems to be working
> pretty well; what else is needed to make it "done" and when should we
> require a Verified+1 to merge again?
For me :
* Add Clang build,
* Add some cmake build too (for Linux and Windows)
* Add test suite (for Linux and Windows
* May be switch to build with Windows 64Bits (if it is psosible)
* Try to have more speed build...


> Is there a way to require a +1 from the
> petri-dish specifically?
Yes It is possible to change Gerrit configuration, remove Core (Groups
can modify Verified Label (only Petri-Dish have access to modify
Verified label)

>
> Thanks,
> Evan
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <[email protected]>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:[email protected]?subject=unsubscribe