ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-dev: [Wireshark-dev] The recent changes to proto.c appear to have broken things badly

From: Bill Meier <wmeier@xxxxxxxxxxx>
Date: Sun, 03 Aug 2014 23:20:20 -0400
Specifically:

For some/many/all? dissectors, the protocol never appears in the 'protocol' column', isn't in the list of protos, filters for the protocol don't work. etc etc

I guess something fails with respect to the
proto_tree_add_item(..., proto_..., ...) call.

Oddly enough, the actual dissection for the protocol does appear in the details pane.

I believe the changes (5460d7f & 3da89d6) should be reverted until they are properly tested/fixed.

(When i reverted these two commits to proto.c, things were OK again.

Bill