Wireshark · Ethereal-dev: Re: [Ethereal-dev] Kerberos bild error

[Joerg Mayer <jmayer@xxxxxxxxx>]

On Sat, Mar 27, 2004 at 01:09:11PM +0100, Olivier Biot wrote:
> Feel free to do so, I don't expect any problems on other platforms.
> However, make sure you try this first by renaming the epan/config.h
> into epan/config_unused.h and then try compiling Ethereal. Reason for
> this is that <config.h> with -I. -I.. will first include the config.h
> in epan...

Done. I have had you patch inside my tree from the beginning, and I did
a make maintainer-clean after applying.

> There's another reason why we get those duplicate linkages: today
> we're using the autotools to add stuff directly into CFLAGS, INCLUDES
> and LDFLAGS. A better approach is to define CFLAGS etc per target by
> using configure substitution, something like:
> 
>     # Makefile.am excerpt
>     libethereal_la_CFLAGS = @CFLAGS@ @PCRE_CFLAGS@ @KRB5_CFLAGS@ ...
>     libethereal_la_LDADD = ...
> 
> To me it doesn't make sense to add all library stuff into the global
> CFLAGS.

Full ACK.

  ciao
        Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.