Wireshark
the world's foremost network protocol analyzer
Wireshark-dev: [Wireshark-dev] Should tvb always be != NULL
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Fri, 03 Oct 2008 09:25:07 +0200
Hi list,Bug 2934 brings to light an interesting question: Should proto_tree_add_??? always have a valid tvb? Sounds logical for every call that adds a value, but not so much for _add_text(). The bug states that there are dissectors which make that call without a tvb, and this leads to a crash. Should the (epan and other) code be prepared for tvb == NULL, or should we DISSECTOR_ASSERT(tvb)?
Thanx, Jaap
- Follow-Ups:
- Re: [Wireshark-dev] Should tvb always be != NULL
- From: Guy Harris
- Re: [Wireshark-dev] Should tvb always be != NULL
- Prev by Date: [Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86
- Next by Date: Re: [Wireshark-dev] Should tvb always be != NULL
- Previous by thread: Re: [Wireshark-dev] new plugin for SIMULCRYPT protocol ready forcontribution - can anyone check for code quality etc / helpwith submission as build-in?
- Next by thread: Re: [Wireshark-dev] Should tvb always be != NULL
- Index(es):