Riverbed Cascade Pilot Personal Edition: Take Wireshark to the Next Level - Advanced Triggers and Alerts; Web and VoIP Analytics; Long-Term Trending and Forensics; Deep Packet Analysis with Wireshark

Wireshark-dev: Re: [Wireshark-dev] Small performance improvements to packet-http.c

Date Index Thread Index Other Months All Mailing Lists

Date Prev Date Next Thread Prev Thread Next

From: "Didier" <dgautheron@xxxxxxxx>
Date: Thu, 8 Nov 2007 00:54:14 +0100

Hi,

On Wed, 7 Nov 2007 11:58:24 +0200, Kaul wrote
> Attached please find a version which reverts back the erroneous printf() changes. Sorry.

There's a bug
conv_data->request_method = ep_strndup("POST", 4);
should be
se_strndup

Or better:
stat_info->request_method = "POST"
conv_data->request_method ="POST"

And you can precompute
(headers[i].namelen - 1)

BTW if you're in optimization mood you can play with http://wiki.wireshark.org/Development/Optimization
I'm not sure it compiles for Window though.

Didier

Follow-Ups:
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Stephen Fisher

References:
- [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Kaul
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Kaul
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Andreas Fink
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Kaul
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Kaul

Prev by Date: Re: [Wireshark-dev] [Wireshark-commits] rev 23395: /trunk/ /trunk/epan/: prefs.c prefs.h /trunk/gtk/: layout_prefs.c toolbar.c
Next by Date: Re: [Wireshark-dev] Small performance improvements to packet-http.c
Previous by thread: Re: [Wireshark-dev] Small performance improvements to packet-http.c
Next by thread: Re: [Wireshark-dev] Small performance improvements to packet-http.c
Index(es):
- Date
- Thread