Riverbed Cascade Pilot Personal Edition: Take Wireshark to the Next Level - Advanced Triggers and Alerts; Web and VoIP Analytics; Long-Term Trending and Forensics; Deep Packet Analysis with Wireshark

Wireshark-dev: Re: [Wireshark-dev] Small performance improvements to packet-http.c

Date Index Thread Index Other Months All Mailing Lists

Date Prev Date Next Thread Prev Thread Next

From: Kaul <mykaul@xxxxxxxxx>
Date: Wed, 7 Nov 2007 11:58:24 +0200

Attached please find a version which reverts back the erroneous printf() changes. Sorry.

Y.

On Nov 7, 2007 11:21 AM, Kaul <mykaul@xxxxxxxxx> wrote:

Yes, my bad. I'm just looking if proto_tree_add_string() would be ok.

On Nov 7, 2007 11:05 AM, Andreas Fink <afink@xxxxxxxxxxxxx> wrote:

On 07.11.2007, at 08:56, Kaul wrote:

Attached please find an updated version of the patch (diff'ed against SVN 23387). It removes (as discussed below) the redundant check for request/reply and also changes some printf("%s", string) -> printf(string).

Let's hope the string doesn't contain any "%" symbols or you end up crashing...

Andreas Fink

Fink Consulting GmbH
Global Networks Schweiz AG
BebbiCell AG
IceCell ehf

---------------------------------------------------------------
Tel: +41-61-6666330 Fax: +41-61-6666331 Mobile: +41-79-2457333
Address: Clarastrasse 3, 4058 Basel, Switzerland
E-Mail: andreas@xxxxxxxx
www.finkconsulting.com www.global-networks.ch www.bebbicell .ch
---------------------------------------------------------------
ICQ: 8239353 MSN: msn1@xxxxxx AIM: smsrelay Skype: andreasfink
Yahoo: finkconsulting SMS: +41792457333

Say NO to Power Line Communications: http://www.youtube.com/watch?v=pdcY0Eetvsw

_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev

Attachment: packet-http.c.diff
Description: Binary data

Follow-Ups:
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Didier

References:
- [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Kaul
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Kaul
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Andreas Fink
- Re: [Wireshark-dev] Small performance improvements to packet-http.c
  - From: Kaul

Prev by Date: Re: [Wireshark-dev] Small performance improvements to packet-http.c
Next by Date: Re: [Wireshark-dev] Use of EXTERNALt
Previous by thread: Re: [Wireshark-dev] Small performance improvements to packet-http.c
Next by thread: Re: [Wireshark-dev] Small performance improvements to packet-http.c
Index(es):
- Date
- Thread