Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 8313] new dissector for SML protocol

Date: Fri, 15 Feb 2013 03:51:50 +0000

Comment # 11 on bug 8313 from
> 
> The ENC_ values should be one of ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN for any
> field that is more than one byte in length (and thus has an endianness to
> worry about). ENC_NA is available for single-byte values (that don't have an
> endianness) and for fields like FT_BYTES which designate an arbitrary-length
> array of bytes with no particular interpretation (and thus no particular
> endianness). There are also other encoding values for strings (ASCII vs
> UTF-8 etc) and other specific types, but I don't think any of them apply to
> SML. For more details see doc/README.developer around line 2357.
> 



There's a perl program in the Wireshark tools directory which can be used to
fix up encoding args:

  tools\fix-encoding-args.pl

perl ...\tools\fix-encoding-args.pl

Usage: ...\tools\fix-encoding-args.pl [--action="" [--write]
FILENAME [...]

 --action = "" (default)
   Fix <certain-fcn-names>() encoding arg when possible in FILENAME(s)
   Fixes (if any) are listed on stdout)

 --write     create FILENAME.encoding-arg-fixes (original file with fixes)
             (effective only for fix-all)

 --action = ""
   Find all occurrences of <certain-fcn-names>() statements)
    highlighting the 'encoding' arg

so:

    perl ...\tools\fix-encoding-args.pl --write packet-xxx.c

    should create a packet-xxx.encoding-arg-fixes with the changes.


You are receiving this mail because:
  • You are watching all bug changes.