Wireshark · Ethereal-dev: Re: [Ethereal-dev] [PATCH] EDG on reassembling UDP packets

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

On Wed, 19 Oct 2005, Ulf Lamping wrote:

> Jaap Keuter wrote:
>
> >Hello list,
> >
> >Working with the reassembly functionality Ethereal provides I've found
> >some additional changes had to be made to the EDG 8.4.1:
> >- a typo (made by myself)
> >- fragment_add_seq_check() doesn't take -1 as length remaining
> >- process_reassembled_data() can be called with or without tree, and
> >  is required in both dissection runs
> >- some whitespace stuff
> >
> checked in

Thanx!

> BTW: I don't really like this style:
>
> } else { /* Not last packet of reassembled Short Message */
>
> although this saves a code line, it makes the sources hard to read, IMHO
> better (at least for me) is:
>
> } else {
> 	/* Not last packet of reassembled Short Message */
>
> Hey, lines are cheap, we already have lot's of them ;-)
>
> Regards, ULFL
>

That's cool. I only worked towards the greatest common denominator style.
Mixing styles is even more undesireable than using the 'wrong' style. :)

Jaap.