Wireshark · Ethereal-dev: Re: [Ethereal-dev] patch to allow for field definitions after initialization

[Guy Harris <guy@xxxxxxxxxxxx>]

On Sat, Aug 23, 2003 at 11:47:33PM +0200, Matthijs Melchior wrote:
> Here is a patch to enable dissectors to register fields from
> preferences dialogues, after initialization of the main ethereal
> system. Of course, fields defined in this way will not end up in
> the manual pages....

Checked in.

> Having done this, it brought to light some serious mis behavior
> of the gtk2 code to construct the field name list in routine
> 'dfilter_expr_dlg_new()'.  To solve the problem, I have created
> an new iterator to enumerate the fields for a particular protocol.
> Using this, the code in 'dfilter_expr_dlg_new()' has become much
> nicer!
> It now shows the same protocol name as with gtk1, the short_name.

Checked in.

> While testing the above [and looking for "asn" in the output of -G],
> I found the following:
> 
> P       Packet Encoding Rules (ASN.1 X.691)     per
> 
> This is a serious typo, the P in PER does not refer to a packet,
> it refers to the small number of bits: packed
> 
> Patch to correct it is attached.

Checked in.