Wireshark · Ethereal-dev: Re: [Ethereal-dev] Patch to NDPS dissector

["Greg Morris" <GMORRIS@xxxxxxxxxx>]

Guy,

 

I did make some changes a while back to track for the spx_info->eom flag. This all seemed to work correctly at the time. But recent changes to the fragment code seemed to break it. I just noticed that it wasn't working correctly today. I was working on the defragmentation of NDS packets when I noticed that NDPS was falling into the wrong code segment at run time. This is why I implemented the change.

 

Greg

>>> Guy Harris <guy@xxxxxxxxxxxx> 8/19/2003 2:41:19 PM >>>

On Tuesday, August 19, 2003, at 10:31 AM, Greg Morris wrote:

> I found a bug in the NDPS dissector when defragmenting SPX packet
> fragments. This patch corrects the problem by keying off of the SPX
> info.

Perhaps the correct fix is to use "!spx_info->eom", rather than
"more_fragment", as the last argument to "fragment_add_seq_next()",
i.e. if "spx_info->eom" is true, it's the last fragment, otherwise it
isn't.

(I seem to remember mentioning this a while ago, although I don't have
my mail archives here at work - I'll check them when I go home.)

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev