Wireshark · Ethereal-dev: RE: [Ethereal-dev] patch: packet-sua.c

[Niels Koot <Niels.Koot@xxxxxxxxxxxxx>]

Good catch, the whole idea was that they where not static any more.

Attached a corrected diff -u against 0.9.14


> -----Original Message-----
> From: Guy Harris [mailto:guy@xxxxxxxxxxxx]
> Sent: Thursday, August 07, 2003 8:34 PM
> To: Niels Koot
> Cc: 'ethereal-dev@xxxxxxxxxxxx'
> Subject: Re: [Ethereal-dev] patch: packet-sua.c
> 
> 
> 
> On Thursday, August 7, 2003, at 9:12 AM, Niels Koot wrote:
> 
> > I found out that the SUA sub dissection code I posted earlier 
> > contained the
> > following bugs:
> > - No sub dissection when the 'tree' is NULL
> > - Sub dissection data in global variables is not cleared.
> >
> > The first bug is fixed by also parsing the parameters 
> required for sub
> > dissection in case 'tree' is NULL and the latter by getting rid of 
> > those
> > global variables and using arguments to pass the sub 
> dissection data.
> 
> The variables in "dissect_sua_message()" are static; do they 
> need to be?
>

Attachment: packet-sua.c.diff
Description: Binary data