Wireshark · Ethereal-dev: Re: [Ethereal-dev] Getting an ASSERT error with Ethereal 0.8.18.

[Guy Harris <gharris@xxxxxxxxx>]

On Mon, May 21, 2001 at 10:24:58AM +0200, M.C. van den Bovenkamp wrote:
> I'm using Ethereal for a while now, and loving it. But I'm having a
> problem with the latest version. It blows up with the following ASSERT
> error on some frames:

I've checked in a fix; a patch for it is attached.

> Just tested it: tethereal blows up with the same error (which is
> probably to be expected).

Same dissector code, same crash.

? errs.SUNC
? errs
? packet-sdp.c.CONVERSATION
? errs.MSVC
? epan/charsets.h
Index: packet-rpc.c
===================================================================
RCS file: /usr/local/cvsroot/ethereal/packet-rpc.c,v
retrieving revision 1.57
diff -c -r1.57 packet-rpc.c
*** packet-rpc.c	2001/05/07 20:36:38	1.57
--- packet-rpc.c	2001/05/21 08:51:22
***************
*** 663,673 ****
  				"length: %u", string_length);
  		offset += 4;
  
! 		if (string_tree)
! 			proto_tree_add_string_format(string_tree, hfindex,
! 				tvb, offset, string_length_copy,
! 				string_buffer_print, 
! 				"contents: %s", string_buffer_print);
  		offset += string_length_copy;
  		if (fill_length) {
  			if (string_tree) {
--- 663,681 ----
  				"length: %u", string_length);
  		offset += 4;
  
! 		if (string_tree) {
! 			if (string_data) {
! 				proto_tree_add_string_format(string_tree,
! 				    hfindex, tvb, offset, string_length_copy,
! 					string_buffer_print, 
! 					"contents: %s", string_buffer_print);
! 			} else {
! 				proto_tree_add_bytes_format(string_tree,
! 				    hfindex, tvb, offset, string_length_copy,
! 					string_buffer_print, 
! 					"contents: %s", string_buffer_print);
! 			}
! 		}
  		offset += string_length_copy;
  		if (fill_length) {
  			if (string_tree) {