Wireshark · Ethereal-dev: Re: [Ethereal-dev] old_dissectors

[Guy Harris <guy@xxxxxxxxxx>]

> On Mon, Apr 16, 2001 at 12:04:13AM -0500, Gilbert Ramirez wrote:
> > grep -l NullTvb packet-*.c  is good, too.
> 
> Wouldn't "grep -l BYTES_ARE_IN_FRAME packet-*.c" be an indicator where
> we are still using old style technics?

It'd be an indicator of old-style dissectors that are using the
BYTES_ARE_IN_FRAME macro; not all of them necessarily do.  Looking for
NullTVB is probably the one most likely to find the older ones:

	cranford$ egrep -l NullTVB *.c
	packet-afs.c
	packet-data.c
	packet-dns.c
	packet-isis-clv.c
	packet-isis-hello.c
	packet-isis-lsp.c
	packet-isis-snp.c
	packet-isis.c
	packet-nbns.c
	packet-nfs.c
	packet-rlogin.c
	packet-rpc.c
	packet-rx.c
	packet-smb-browse.c
	packet-smb-common.c
	packet-smb-logon.c
	packet-smb-mailslot.c
	packet-smb-pipe.c
	packet-smb.c
	packet-socks.c

(the plugins are now all new-style dissectors, using tvbuffs).

"packet-rpc.c" awaits only the conversion of "packet-nfs.c", and
"packet-data.c" awaits the conversion of dissectors using
"old_dissect_data()":

	cranford$ egrep -l old_dissect_data *.c
	packet-data.c
	packet-dns.c
	packet-nbns.c
	packet-socks.c