On Mar 11, 2014, at 3:01 PM, Guy Harris <guy@xxxxxxxxxxxx> wrote:
>
> On Mar 11, 2014, at 11:18 AM, Hadriel Kaplan <hadriel.kaplan@xxxxxxxxxx> wrote:
>
>> I see you have the 'pip install git-review' stuff on that page... fwiw, I've never gotten git-review to work on my Mac. I got it installed with pip, but issuing any 'git review' command doesn't work. I don't *think* it's a path problem, but instead whatever mechanics git-review did to hook itself into git's command parser
>
> Git's command parser appears to be something similar to
>
> system("git-" || the arguments to git);
>
>> (through Python it seems)
>
> $ which git-review
> /usr/local/bin/git-review
> $ file `which git-review`
> /usr/local/bin/git-review: Python script, ASCII text executable
>
> so git-review is just a Python script with a #! header, so that an exec-family call (which includes posix_spawn() on systems, such as newer versions of OS X, that have it) on that file will run the Python interpreter on it.
Ahhh. So then it *is* a path problem. Naturally 'pip install' put the "installed" binary in:
/opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin/
on my machine. Because, ya know, it's so useful there.
:)
Thanks for the info - it workie now.
-hadriel
