2011/4/21 Stig Bjørlykke
<stig@xxxxxxxxxxxxx>
On Thu, Apr 21, 2011 at 6:01 PM, <alagoutte@xxxxxxxxxxxxx> wrote:
> Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
- flags1_tree = proto_item_add_subtree(flags1_item,
ett_pn_io_profisafe_f_parameter_prm_flag1);
+ proto_item_add_subtree(flags1_item,
ett_pn_io_profisafe_f_parameter_prm_flag1);
This fix is completely wrong!
You have no need for a proto_item_add_subtree without using the return value.
In this case I suppose flags1_tree should be use in the next
dissect_dcerpc_uint8 calls instead of using flags1_item.
Hi,
I based my change on the previous revision of jmayer (rev36724) in this file ...
and there is the same mistake !
I can not fix the issue tonight, I do it tomorrow
Regards,
