Wireshark-bugs: [Wireshark-bugs] [Bug 5337] Crash when use Export object SMB
Date: Mon, 24 Jan 2011 11:22:59 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5337

Bill Meier <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Bill Meier <[email protected]> 2011-01-24 14:22:57 EST ---
Crash fixed in SVN #35638.


Jose:

It's always appreciated when someone takes the time and effort to understand
and debug an issue and propose a fix. Thanks !


Upon reviewing the original code in export_object_smb.c which contained the
bug, I came to the conclusion that it would be better to simplify the "remember
packets seen" code to use a GHashTable instead of a GTree. 

This did away altogether with the need for the "compare callback" (which had
the bug) and for two g_malloc's (for every packet remembered).

I've also noted in the comments in the source that it might be useful at some
point to investigate further as to why the "remember packets seen" logic is
deemed to be needed.

It appears there's a bug wherein if a new file is opened and read while the
object_export_smb window is open that the existing window isn't properly closed
(or, at least, the associated state isn't cleared).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.