Wireshark-bugs: [Wireshark-bugs] [Bug 5337] Crash when use Export object SMB
Date: Tue, 25 Jan 2011 02:24:05 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5337

--- Comment #9 from Jose Pico <[email protected]> 2011-01-25 02:24:02 PST ---
Hi Bill,

thank you very much for your interest and your comments. 

Regarding the use of a GHashTable structure, I think you're completely right,
so thanks a lot for the correction.

Regarding the other issues, I'm studying them and I'll come back to you with
some feedback.

Jose

(In reply to comment #8)
> Crash fixed in SVN #35638.
> 
> 
> Jose:
> 
> It's always appreciated when someone takes the time and effort to understand
> and debug an issue and propose a fix. Thanks !
> 
> 
> Upon reviewing the original code in export_object_smb.c which contained the
> bug, I came to the conclusion that it would be better to simplify the "remember
> packets seen" code to use a GHashTable instead of a GTree. 
> 
> This did away altogether with the need for the "compare callback" (which had
> the bug) and for two g_malloc's (for every packet remembered).
> 
> I've also noted in the comments in the source that it might be useful at some
> point to investigate further as to why the "remember packets seen" logic is
> deemed to be needed.
> 
> It appears there's a bug wherein if a new file is opened and read while the
> object_export_smb window is open that the existing window isn't properly closed
> (or, at least, the associated state isn't cleared).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.