Wireshark · Ethereal-dev: Re: Patch in reassemble.c (was Re: [Ethereal-dev] Crash in ethereal 0.10.8, somewhat reproducible)

Ethereal-dev: Re: Patch in reassemble.c (was Re: [Ethereal-dev] Crash in ethereal 0.10.8, some

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>

Date: Mon, 25 Jul 2005 11:05:39 -0700

I've checked in a change to back out the change to not copy data ifFD_NOT_MALLOCED is set, and to add some offset/length checks before thecopy is done.

I'm not sure how the crash happened (as I don't have any captures thatproduce it); hopefully the checks will prevent the crash *AND* will, inthe error messages they print in those cases, indicate what checksreally need to be done.

Follow-Ups:
- Re: Patch in reassemble.c (was Re: [Ethereal-dev] Crash in ethereal 0.10.8, somewhat reproducible)
  - From: Peter Johansson

References:
- Re: Patch in reassemble.c (was Re: [Ethereal-dev] Crash in ethereal 0.10.8, somewhat reproducible)
  - From: Guy Harris
- Re: Patch in reassemble.c (was Re: [Ethereal-dev] Crash in ethereal 0.10.8, somewhat reproducible)
  - From: Peter Johansson
- Re: Patch in reassemble.c (was Re: [Ethereal-dev] Crash in ethereal 0.10.8, somewhat reproducible)
  - From: Guy Harris

Prev by Date: Re: [Ethereal-dev] wishlist: hash of packet-data
Next by Date: Re: [Ethereal-dev] zlib version upgrade - security issue
Previous by thread: Re: Patch in reassemble.c (was Re: [Ethereal-dev] Crash in ethereal 0.10.8, somewhat reproducible)
Next by thread: Re: Patch in reassemble.c (was Re: [Ethereal-dev] Crash in ethereal 0.10.8, somewhat reproducible)
Index(es):
- Date
- Thread