Wireshark · Ethereal-dev: [Ethereal-dev] overflow in ftype-string.c

[Pekka Pietikainen <pp@xxxxxxxxxx>]

Hiya. 

I recently noticed (well, recent gcc/glibc pointed it out by
making tethereal crash when processing a certain packet :-) ) that 
there's a problem in string_to_repr, it does a sprintf(hex,"%02x",val), but 
doesn't reserve the space for the terminating null. The following 
fixes the issue:

--- ethereal-0.10.9/epan/ftypes/ftype-string.c~	2005-02-03 13:40:43.000000000 +0200
+++ ethereal-0.10.9/epan/ftypes/ftype-string.c	2005-02-03 13:40:43.000000000 +0200
@@ -105,7 +105,7 @@
 {
 	gchar *p, c;
 	char *bufp;
-	char hex[2];
+	char hex[3];
 
 	if (rtype == FTREPR_DFILTER) {
 		bufp = buf;