Guy Harris wrote:
Ulf Lamping said:
Several days ago, the dissector files packet-xxx were moved from the
top-level dir into epan/dissectors.
Is there a reason, to keep the DISSECTOR_SUPPORT_xxx files still in the
top-level dir?
I see no reason to keep the DISSECTOR_SUPPORT_INCLUDES files there, if the
.c files corresponding to them have moved; they should move to the
directories where the .c files are.
Some of those are still in the top-level directory, such as print.h; we
should decide where print.c belongs. (It has two levels of print support
- low-level routines for printing text to files or printers, independent
of the type of text being printed, and higher-level routines that print a
protocol tree and hex data to a print_stream_t and that print P{D,S}ML to
a file. Those should perhaps be split into two files, with the latter
probably belonging in libethereal as they know about libetherealisms such
as protocol trees, but with the former perhaps belonging elsewhere.)
Then there's "util.h", which includes both stuff that probably belongs in
libethereal and stuff that doesn't.
The same applies to the DISSECTOR_SUPPORT_SRC files.
It's not only the question if the files belong in libethereal, it's also
if they belong to epan or epan/dissectors or elsewhere.
We might start to move the files which are out of question, but which
one's are out of question and where do they have to go?
Regards, ULFL
