Ethereal-dev: Re: [Ethereal-dev] packet-*.[ch] file movement imminent

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Gilbert Ramirez <[email protected]>
Date: Sun, 18 Jul 2004 10:19:43 -0500
On Sunday 18 July 2004 06:21, Lars Roland wrote:
> Ulf Lamping schrieb:
> > Joerg Mayer wrote:
> >> On Sat, Jul 17, 2004 at 10:06:24PM -0500, Gilbert Ramirez wrote:
> >>> Now that subversion is in place for SCM, I've prepared a patch which
> >>> moves the packet-*.[ch] files from the top-level directory to a
> >>> directory named "epan/dissectors". I've changed the Makefile.nmake's,
> >>> but I have no resource to test on Win32.
> >>
> >> Could you strip the leading packet- from the filenames while you are
> >> at it?
> >>
> >> ciao
> >>   Joerg
> >
> > Is this really a good idea?
> >
> > We have a lot of files with the actual dissectors (prefix packet-) and
> > some other helper files at the same level without it.
> >
> > If you remove the prefixes, you cannot distinguish between real
> > dissectors and helper files.
> >
> > But I don't know if this difference is essential, both approaches would
> > be ok for me.
> >
> > Regards, ULFL
>
> I would like to have dissector sources and dissector-helper sources
> moved to epan/dissectors to make life and nmake makefiles easier.
> Thus I'd like to have our naming convention for dissectors kept.
>
> Regards, Lars.

Yes, I too like keeping "packet-" on the dissector filenames.

I haven't moved the dissector-helper sources yet (the 
DISSECTOR_SUPPORT_INCLUDES files). I think I'll wait on that until after this 
first move is done.

-gilbert