Wireshark · Ethereal-dev: RE: [Ethereal-dev] Moving the uncompress_packet function inpacket -slsk.c

[Biot Olivier <Olivier.Biot@xxxxxxxxxxx>]

Great!

Maybe you should be able to specify the compression algorithm as an argument
to the function?

Regards,

Olivier

|-----Original Message-----
|From: Ronnie Sahlberg
|
|Hi,
|
|That sounds to me like a very worthwhile and valuable project 
|for Ethereal.
|I am certain there are other protocols as well where this 
|functionality will
|come in handy,
|maybe IPSec used with a compression transform instead of a encryption
|transform (IPComp).
|
|I have not looked into the problemspace but maybe one can 
|utilize functions
|from libz which we already
|link with in most cases (and where libz is not available the 
|API would just
|return NULL instead of a tvbuff*?)
|
|I say, good idea and useful, try to make the API generic 
|enough so that it
|will be easy for those that come later to
|just plug into it to enable this for whatever other protocols might do
|compression.
|
|
|
|----- Original Message ----- 
|From: Jerry Talkington
|
|> Howdy Folks!
|>
|> I was looking at adding gzip/deflate decompression in HTTP 
|packets, and
|> it appears that there is already code for decompression in
|> packet-slsk.c.  It's now static as uncompress_packet().
|>
|> I'm proposing a move it to tvbuff.c as
|> tvbuff_t *tvb_uncompress(tvbuff_t *tvb, int offset, int comprlen);
|>
|> Let me know if that's acceptable, or what else to do, and 
|I'll go ahead
|> and add gzip decoding (with an option) to HTTP.