Really the only slightly odd thing was that when you created a new filter,
the string "filter" appeared in white (it is an invalid string and might
have more usefully appear immediately as red).
This new attached patch ensures that the initial colour is appropriate in
all cases. There is also a fresh diff for menu.c to make coloring rules
available when no packets have been captured or loaded.
Please apply.
Regards, Martin
----- Original Message -----
From: "Richard Urwin" <richard@xxxxxxxxxxxxxxx>
To: "Ethereal development" <ethereal-dev@xxxxxxxxxxxx>
Sent: 07 April 2004 17:53
Subject: Re: [Ethereal-dev] Coloring rules dialog
> On Wednesday 07 Apr 2004 11:21 am, Martin Mathieson wrote:
> > The top-level dialog that has the list of filters is unaffected.
> >
> > It is only the dialog that appears when you add a new rule or edit an
> > existing rule that is affected. In both cases, both the name of the
> > rule and the filter expression start off coloured according to any
> > previous color settings for this rule. It is only once you start to
> > edit the filter expression that its colour may change (the name of
> > the rule keeps the current colour selection of the rule).
>
> What is preventing us making the initial colour of the filter correct?
>
> > Despite my earlier caveat I find this behaviour OK in use.
> > Could/should these 2 little patches be applied?
>
> Yes, IMO, but I'd like to see that initial colour problem fixed if
> possible.
>
> --
> Richard Urwin
>
Attachment:
menu.c.diff
Description: Binary data
Attachment:
color_dlg.c.diff
Description: Binary data
