Hello Ritchie,
That looks good. The only problem could be that the line with all this
information is getting too long. That is the problem with this tag
decoding I am facing all the time: the field wlan_mgt.tag.interpretation
contains too much information. Does anybody know how to split this up?
What I do now is create multiple lines with wlan_mgt.tag.interpretation
but I think that filtering on this will fail.
The answer to your question regarding signed is: cast the last unsigned
char to a (gint8).
Diff:
- tag_data_ptr[i], tag_data_ptr[i +
1],tag_data_ptr[i + 2]);
+ tag_data_ptr[i], tag_data_ptr[i +
1],(gint8)tag_data_ptr[i + 2]);
Greetings,
Martijn Schipper
Software Quality Engineer
GlobespanVirata BV
Rembrandtlaan 1a
3723 BG Bilthoven
The Netherlands
Tel: +31 (0)30 2296076
Fax: +31 (0)30 2296061
E-mail: Martijn.Schipper@xxxxxxxxxxxxxxxxxxx
Internet: www.globespanvirata.com
-----Original Message-----
From: Ritchie [mailto:ritchie@xxxxxxxxxxxxxxx]
Sent: vrijdag 19 september 2003 5:49
To: Schipper, Martijn (GSPN); ethereal-dev@xxxxxxxxxxxx
Subject: Re: [Ethereal-dev] Patch to enable country information tag
patch in802.11
Martijn - Thank for the feedback. I implemented your corrections and
then
added the dissection of the FH Hopping Parameter Tag.
Could someone please verify that I implemented the signed power level
correctly? I was under the impression that switching %u with %d would
correct this one, but it didn't seem to work for me. I use KHexEdit to
create negative values, but Ethereal still prints the output power as an
unsigned value. I hope that's not too basic of a question, but I've
never
really programmed anything before. That's also why I started with only
one
start channel, channels, and power combo.
Thanks again,
Ritchie
----- Original Message -----
From: "Schipper, Martijn (GSPN)" <martijn.schipper@xxxxxxxxxxxx>
To: "Ritchie" <ritchie@xxxxxxxxxxxxxxx>; <ethereal-dev@xxxxxxxxxxxx>
Sent: Tuesday, September 16, 2003 1:51 AM
Subject: RE: [Ethereal-dev] Patch to enable country information tag
patch
in802.11
Hello Ritchie,
Great you added 802.11d decoding. However there are some errors.
1) The output power is signed and not unsigned.
2) The units for the output power are dBm and not dbi.
3) You decode one start channel, number of channels and output power
combination. However there can, and will, be more of these combinations
in the Information Element (for 802.11a (5 GHz) most likely 3).
Greetings,
Martijn Schipper
Software Quality Engineer
GlobespanVirata BV
Rembrandtlaan 1a
3723 BG Bilthoven
The Netherlands
Tel: +31 (0)30 2296076
Fax: +31 (0)30 2296061
E-mail: Martijn.Schipper@xxxxxxxxxxxxxxxxxxx
Internet: www.virata.com
> -----Original Message-----
> From: Ritchie [mailto:ritchie@xxxxxxxxxxxxxxx]
> Sent: vrijdag 12 september 2003 22:13
> To: ethereal-dev@xxxxxxxxxxxx
> Subject: [Ethereal-dev] Patch to enable country information tag patch
> in802.11
>
> Here is a patch for the 802.11 dissector that will show the country
> information tag found in beacon frames.
>
> I have attached the diff to be applied against the latest version of
> packet-ieee80211.c.
>
> Thanks,
> Ritchie
>
> http://tipsybottle.com
