On Thu, Jan 02, 2014 at 07:12:27PM +0100, Joerg Mayer wrote:
> On Thu, Jan 02, 2014 at 05:04:10PM +0000, alagoutte@xxxxxxxxxxxxx wrote:
> > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54557
> >
> > User: alagoutte
> > Date: 2014/01/02 05:04 PM
> >
> > Log:
> > Add About window for Wireshark Qt
>
> Great! Just some nitpicks:
> - The plugins list is empty (maybe something wrong with my setup?)
> - The authors list is not formatted
> - The release notes have not been updated
The nice part of long train rides: Time to revisit some "old" problems:
I did some printf debugging and the "simple" reason is: The about dialog
is created before the scan for plugins is done. Please fix :-)
Ciao
Jörg
--
Joerg Mayer <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
Index: about_dialog.cpp
===================================================================
--- about_dialog.cpp (revision 54625)
+++ about_dialog.cpp (working copy)
@@ -87,6 +89,8 @@
void AboutDialog::plugins_scan()
{
#ifdef HAVE_PLUGINS
+printf("About:Plugins dump all\n");
+plugins_dump_all();
plugins_get_descriptions(plugins_add_description, ui->tbPlugins);
#endif
Index: main.cpp
===================================================================
--- main.cpp (revision 54625)
+++ main.cpp (working copy)
@@ -840,6 +841,8 @@
/* Scan for plugins. This does *not* call their registration routines;
that's done later. */
scan_plugins();
+printf("Main:Plugins dump all\n");
+plugins_dump_all();
/* Register all libwiretap plugin modules. */
register_all_wiretap_modules();
