On Dec 24, 2013, at 12:45 PM, Pascal Quantin <pascal.quantin@xxxxxxxxx> wrote:
> I would vote for proto_tree_add_gsm_7bits_item() as TS 23.038 talks about 8 bits data and UCS2 encoding also and defines this alphabet as GSM 7bit. We should not put SMS in its name as it has a much wider use in 3GPP / 3GPP2.
3GPP2 isn't GSM. :-) (Or, speaking as a North American, perhaps that should be :-( - at least with LTE maybe everybody will be doing their mobile phone/mobile-broadband-not-called-WiMAX-etc. stuff the same way, even if, with LTE, you are in a maze of twisty little frequency bands, all different. Maybe someday in my lifetime all mobile phones/tablets/mobile-phone-modems/etc. will be world phones/etc.....)
That's why I'd vote for not putting "gsm" into the name, either; it's also used by ANSI IS-637-A.
And a "7 bit item" could be a single 7-bit field, so I'd vote for proto_tree_add_ts_23_038_7bits_item().
