Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trun

From: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>

Date: Thu, 21 Apr 2011 16:33:15 +0200

2011/4/21 Stig Bjørlykke <stig@xxxxxxxxxxxxx>

On Thu, Apr 21, 2011 at 3:32 PM, <alagoutte@xxxxxxxxxxxxx> wrote:
> Fix Dead Store (Dead nested assignment) Warning found by Clang

- msg_type = tvb_get_ntohs(tvb, (tmp_idx+=2));
+ msg_type = tvb_get_ntohs(tvb, tmp_idx);

Are you sure this is correct? What about "tmp_idx+2"?

Oups !
Fix in Rev 36768

References:
- Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-l2tp.c
  - From: Stig Bjørlykke

Prev by Date: [Wireshark-dev] Compilation failure (mv: cannot stat `.deps/privileges.Tpo': No such file or directory)
Next by Date: [Wireshark-dev] Wireshark
Previous by thread: Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-l2tp.c
Next by thread: [Wireshark-dev] Compilation failure (mv: cannot stat `.deps/privileges.Tpo': No such file or directory)
Index(es):
- Date
- Thread