Wireshark-dev: [Wireshark-dev] wireshark -- atm n:1 dissector

From: "Tamazov, Artem" <artem.tamazov@xxxxxxxxxxx>
Date: Tue, 7 Apr 2009 09:17:03 -0500

 

Hello Francesco,

 

Recently I've implemented ATM N:1 dissection and get into merge conflict after SVN merge.

It looks that we have the same plans regarding Wireshark ;)

I mean:    

    DONE:

        - ATM N-to-One Cell Mode (with CW)

        - ATM N-to-One Cell Mode (no CW)

    TODO:

        - ATM One-to-One Cell Mode

        - ATM AAL5 SDU Mode

        - ATM AAL5 PDU Mode

 

Well, let's decide how to handle this.

 

It first glance, my implementation hase more features related to validation of packets.

Also it supports some old equipment (it has a couple of options for this).

Your implementation more extensively uses existing ATM dissector, which is important.

 

For now I am going to look at your ATM PW dissector with more attention.

Also I would like you to look at my code.

Then we can decide how to resolve this situation.

 

If you agree, I will send my patches to you (I will prepare them so you will not experience merge conflicts).

What is your opinion?

 

Regards,
Artem Tamazov//

 

 

============================================================
The information contained in this message may be privileged
and confidential and protected from disclosure. If the reader
of this message is not the intended recipient, or an employee
or agent responsible for delivering this message to the
intended recipient, you are hereby notified that any reproduction,
dissemination or distribution of this communication is strictly
prohibited. If you have received this communication in error,
please notify us immediately by replying to the message and
deleting it from your computer. Thank you. Tellabs
============================================================