Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 27959: /trunk/epan/ /trunk/epan/dissectors/: packet-wcp.c packet-x11.c /trunk/epan/: tvbuff.c tvbuff.h

From: Gerald Combs <gerald@xxxxxxxxxxxxx>
Date: Sun, 05 Apr 2009 09:25:22 -0700

Guy Harris wrote:

On Apr 4, 2009, at 12:34 PM, gerald@xxxxxxxxxxxxx wrote:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=27959

User: gerald
Date: 2009/04/04 12:34 PM

Log:
tvbuff.[ch]: Accept more size_t's.

Should people be passing sizeof's to tvb_new_subset(), tvb_new_real_data(), etc.? There's no guarantee that a C structure matches a data structure within a packet, due to padding (including padding at the end of the structure, in some compilers), etc..

Probably not. I'll back out the change.