Wireshark

  • Riverbed Technology
  • WinPcap
the world's foremost network protocol analyzer
  • Wireshark
    • About
    • Download
    • Blog
  • Get Help
    • Ask a Question
    • FAQs
    • Documentation
    • Mailing Lists
    • Online Tools
    • Wiki
    • Bug Tracker
  • Develop
    • Get Involved
    • Developer's Guide
    • Browse the Code
    • Latest Builds

Wireshark-dev: Re: [Wireshark-dev] use "else" instead of "ifndef _WIN32"

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next


From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Sun, 11 Jan 2009 19:17:11 +0100

Committed revision 27212.

Toralf Förster wrote:
Hi,

I'm wondering, why within dumpcap the ifdef _WIN32 is handle in 2 different ways within the same source file or - OTOH - should the patch below be applied ? :

tfoerste@n22 ~/devel/wireshark $ svn diff --diff-cmd diff dumpcap.c
Index: dumpcap.c
===================================================================
--- dumpcap.c   (revision 27209)
+++ dumpcap.c   (working copy)
@@ -2332,10 +2332,9 @@

 #ifdef _WIN32
   WSADATA              wsaData;
-#endif  /* _WIN32 */
-#ifndef _WIN32
+#else
   struct sigaction action, oldaction;
-#endif
+#endif  /* _WIN32 */

   gboolean             start_capture = TRUE;
   gboolean             stats_known;




  • References:
    • [Wireshark-dev] use "else" instead of "ifndef _WIN32"
      • From: Toralf Förster
  • Prev by Date: [Wireshark-dev] use "else" instead of "ifndef _WIN32"
  • Next by Date: Re: [Wireshark-dev] PPPoED protocol preferences
  • Previous by thread: [Wireshark-dev] use "else" instead of "ifndef _WIN32"
  • Next by thread: [Wireshark-dev] Pcap traces for SMS packets
  • Index(es):
    • Date
    • Thread

Wireshark and the "fin" logo are registered trademarks of the Wireshark Foundation