Wireshark

  • Riverbed Technology
  • WinPcap
the world's foremost network protocol analyzer
  • Wireshark
    • About
    • Download
    • Blog
  • Get Help
    • Ask a Question
    • FAQs
    • Documentation
    • Mailing Lists
    • Online Tools
    • Wiki
    • Bug Tracker
  • Develop
    • Get Involved
    • Developer's Guide
    • Browse the Code
    • Latest Builds

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3183] checkAPI.pl Makefile's rule only checks C files but there's "Not terminated: value_string" errors in .h too

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next


From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Sat, 10 Jan 2009 00:13:45 +0100

Hi,

I think that it is more a matter of personal taste of the original author of these files. If we want this changed we need to define more stringent style guides _and_ enforce them. It takes enough effort to get it bug free.

Thanx,
Jaap

Bill Meier wrote:
bugzilla-daemon@xxxxxxxxxxxxx wrote:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3183

--- Comment #2 from Guy Harris <guy@xxxxxxxxxxxx>  2009-01-09 10:09:40 PDT ---
Why are we defining and initializing, rather than just declaring, value_string
tables in header files?

+1 !



  • References:
    • Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3183] checkAPI.pl Makefile's rule only checks C files but there's "Not terminated: value_string" errors in .h too
      • From: Bill Meier
  • Prev by Date: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3183] checkAPI.pl Makefile's rule only checks C files but there's "Not terminated: value_string" errors in .h too
  • Next by Date: [Wireshark-dev] PPPoED protocol preferences
  • Previous by thread: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3183] checkAPI.pl Makefile's rule only checks C files but there's "Not terminated: value_string" errors in .h too
  • Next by thread: [Wireshark-dev] PPPoED protocol preferences
  • Index(es):
    • Date
    • Thread

Wireshark and the "fin" logo are registered trademarks of the Wireshark Foundation