Wireshark-dev: Re: [Wireshark-dev] Unistim plugin

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 12 Jun 2007 06:13:21 +0200

On Mon, Jun 11, 2007 at 06:45:25PM -0400, Newton, Don wrote:
> It has been tested on both Linux and Windows XP.  

Please perform some fuzz testing. This is likely to crash the code:
None(?) of the value_strings are properly terminated {0, NULL}

Also, please add the standard header to all the source files.

I haven't looked at the code, just skimmed over the beginnings of the
patch.

 Ciao
       Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.