Wireshark-dev: Re: [Wireshark-dev] AMQP dissector patch

From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Sun, 10 Jun 2007 17:19:47 -0700

Thanks, that's no problem then.  I just tried applying your patch, but 
it failed on all hunks.  Would it be possible to do an svn update and 
regenerate the patch?  Is any part of this patch included in your patch 
that Ronnie committed on March 28th?  That was revision 21254.  The 
filename you attached claims it is against 21226 so that could be 
causing the problem.

On Fri, Jun 01, 2007 at 07:15:38AM +0200, Martin Sustrik wrote:
> Steve,
> 
> The problem is that the code is generated from the protocol 
> specification. If I was to find out which parameters actually need _U_ 
> and which do note, the code generation would get considerably more 
> complex (two passes instead of single one).
> 
> Martin
> 
> From: Stephen Fisher <stephentfisher@xxxxxxxxx>
> Date: Mon, 21 May 2007 14:02:33 -0700
> 
> On Mon, May 21, 2007 at 02:30:59PM +0200, Martin Sustrik wrote:
> 
>  > Here's the patch for following issues:
>  >
>  > - If there are several AMQP frames in single TCP packet, all of them are
>  > shown in the 'info' column
>  > - AMQP heartbeat is dissected correctly, it doesn't assert any more
>  >
>  > Can you please apply the patch to the SVN?
> 
> I have one question before applying the patch.  Both in your patch and
> in the existing code, many functions have _U_ for every paramter in
> functions, even when those variables are used within the function.  Any
> idea why that is?
> 
> 
> Steve
> 
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev