Wireshark

  • Riverbed Technology
  • WinPcap
the world's foremost network protocol analyzer
  • Wireshark
    • About
    • Download
    • Blog
  • Get Help
    • Ask a Question
    • FAQs
    • Documentation
    • Mailing Lists
    • Online Tools
    • Wiki
    • Bug Tracker
  • Develop
    • Get Involved
    • Developer's Guide
    • Browse the Code
    • Latest Builds

Wireshark-dev: Re: [Wireshark-dev] patch for BGP MDT decods

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next


From: "Aamer Akhter" <aakhter@xxxxxxxxx>
Date: Mon, 4 Jun 2007 12:27:02 -0400

Joerg,

Thanks for catching this. It was a typo. Revised diff attached.

"Joerg Mayer" <jmayer-2TuS4uRBb1yzQB+pC5nmwQ@xxxxxxxxxxxxxxxx> wrote in
message news:<20070604052713.GA32229@xxxxxxxxxxxxxxxxxxxxxxxxx>...
On Sun, Jun 03, 2007 at 10:19:41PM -0400, Aamer Akhter wrote:
> Please find attached a patch for support of
> 'draft-nalawade-idr-mdt-safi'. This draft is the basis of the current
> Multicast MVPN BGP support.

What's the reason for this change:

@@ -556,7 +598,7 @@
                                                 break ;
                                         default:
                                                 length = 0 ;
-                                                g_snprintf(buf, buf_len,
+"Unknown (0x%04x) labeled VPN IPv4 address format",rd_type);
+                                                g_snprintf(buf, buf_len,
+"Unknown (0x%0x) labeled VPN IPv4 address format",rd_type);
                                                 break;
                                 }


> Also, is there an emacs settings file for conforming to the wireshark
> indentation spec?

There isn't one. Each file may have its own indentation style. We just
try to avoid having too many styles in one file :-)

Ciao
      Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev

----------

Attachment: mdt-complete.diff.gz
Description: GNU Zip compressed data

  • Follow-Ups:
    • Re: [Wireshark-dev] patch for BGP MDT decods
      • From: Sebastien Tandel
  • Prev by Date: Re: [Wireshark-dev] patch for BGP MDT decods
  • Next by Date: Re: [Wireshark-dev] File:Import?
  • Previous by thread: Re: [Wireshark-dev] patch for BGP MDT decods
  • Next by thread: Re: [Wireshark-dev] patch for BGP MDT decods
  • Index(es):
    • Date
    • Thread

Wireshark and the "fin" logo are registered trademarks of the Wireshark Foundation