Wireshark-dev: Re: [Wireshark-dev] [Patch] pragma warning

From: Sebastien Tandel <sebastien@xxxxxxxxx>
Date: Tue, 03 Apr 2007 21:57:39 +0200

Now these changes are in the svn tree.

Note that I've moved some dissectors from DISSECTOR_SRC to
CLEAN_DISSECTOR_SRC but there are many others which could already be
moved to CLEAN_DISSECTOR_SRC.


Regards,
Sebastien Tandel

>> I made it partly for the Unix side. (Makefile.common and Makefile.am
>> affected).
>> The Makefile is, in fact, building now four libraries :
>> - asn dissectors : libasndissectors.la
>> - pidl dissectors : libpidldissectors.la
>> - normal dissectors : libdissectors.la *and* libcleandissectors.la. I
>> separated it in two libraries temporarily. The source files used to
>> build libcleandissectors.la do not generate warning anymore and the
>> -Werror is used to compile them. If we patch a dissector and it doesn't
>> generate warning anymore, we have to move the filename dissector from
>> DISSECTOR_SRC to CLEAN_DISSECTOR_SRC in epan/dissectors/Makefile.common.
>>
>> You can define specific cflags with, for example,
>> libpidldissectors_la_CFLAGS.
>>     
>
> Did you already commit these changes?  I don't see them in my svn tree.  
> We're still compiling epan/dissectors with a ton of warnings from 
> auto-generated dissectors on Unix.
>