On Wed, Jan 31, 2007 at 09:20:25PM +0700, Kriang Lerdsuwanakij wrote:
> While I reading source code of IuUP dissector, I notice some obvious
> bugs inside the code. One is a missing assignment that causes the
> following "if (iuup_circuit)" block to never execute. Another is wrong
> field names.
>
> Althoug both won't show up in final result (for the first bug, the
> call to g_hash_table_insert several lines later will do the right
> thing anyway; for the second bug, there is no services utilizing more
> than 3 subflows), I think it is better to have them fixed. Patch is in
> the attachment.
Thanks for your contribution. I had a question before committing it
though. Why do only some of the fields say "len" after them and the
first three don't even after your patch?
Thanks,
Steve
