Wireshark

  • Riverbed Technology
  • WinPcap
the world's foremost network protocol analyzer
  • Wireshark
    • About
    • Download
    • Blog
  • Get Help
    • Ask a Question
    • FAQs
    • Documentation
    • Mailing Lists
    • Online Tools
    • Wiki
    • Bug Tracker
  • Develop
    • Get Involved
    • Developer's Guide
    • Browse the Code
    • Latest Builds

Wireshark-dev: [Wireshark-dev] Patch to packet-exec.c to fix a comment

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next


From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Thu, 3 Aug 2006 16:00:33 -0700

I was looking at the dissector I wrote recently, packet-exec.c, to
remember how to handle conversations and I noticed a comment that isn't
clear.  It would throw someone off because it isn't how the dissector
was finally written :).  Please apply the attached patch to correct
this.


Thanks,
  Steve
Index: epan/dissectors/packet-exec.c
===================================================================
--- epan/dissectors/packet-exec.c	(revision 18829)
+++ epan/dissectors/packet-exec.c	(working copy)
@@ -69,11 +69,9 @@
 #define EXEC_PASSWORD_LEN 16
 #define EXEC_COMMAND_LEN 256 /* Longer depending on server operating system? */
 
-/* Initialize the structure that will be tied to each conversation
- * This is used to display the username (and command?) in the INFO column of
- * each packet as well as displaying hidden fields so filtering by these
- * does not only show the first packet or two, but shows the entire 
- * conversation */
+/* Initialize the structure that will be tied to each conversation.
+ * This is used to display the username and/or command in the INFO column of
+ * each packet of the conversation. */
 
 typedef enum {
 	NONE                 = 0,
  • Follow-Ups:
    • Re: [Wireshark-dev] Patch to packet-exec.c to fix a comment
      • From: Jaap Keuter
  • Prev by Date: Re: [Wireshark-dev] GnuTLS on Windows
  • Next by Date: Re: [Wireshark-dev] Patch to packet-exec.c to fix a comment
  • Previous by thread: Re: [Wireshark-dev] bug in follow TCP ASCII
  • Next by thread: Re: [Wireshark-dev] Patch to packet-exec.c to fix a comment
  • Index(es):
    • Date
    • Thread

Wireshark and the "fin" logo are registered trademarks of the Wireshark Foundation