Wireshark-dev: Re: [Wireshark-dev] Patch to conversation.c

From: "Anders Broman" <a.broman@xxxxxxxxx>
Date: Wed, 2 Aug 2006 21:50:36 +0200

Checked in.
Brg
Anders

-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Peter Johansson
Skickat: den 31 juli 2006 17:51
Till: wireshark-dev@xxxxxxxxxxxxx
Ämne: [Wireshark-dev] Patch to conversation.c

Hi,

the supplied patch fixes a problem where the options value should really
be used from the conversation found (using
conversation_lookup_hashtable(...) to create a new conversation based on
the already stored conversation template (the CONVERSATION_TEMPLATE bit is
set in the stored conversation) rather from the options argument passed to
the function(s).

This solves a problem that otherwise shows itself where
"DISSECTOR_ASSERT(!(conv->options & CONVERSATION_TEMPLATE) && "Use the
conversation_create_from_template function when the CONVERSATION_TEMPLATE
bit is set in the options mask");" fails sometimes.

/ Regards, Peter