Wireshark-commits: [Wireshark-commits] rev 20974: /trunk/doc/ /trunk/doc/: README.developer

From: jake@xxxxxxxxxxxxx
Date: Mon, 05 Mar 2007 20:25:55 GMT

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20974

User: jake
Date: 2007/03/05 08:25 PM

Log:
 From Richard van der Hoff:
 I've had a good look at the code in packet-tcp.c, and whilst it's
 somewhat impenetrable, I've come to the conclusion that it just doesn't
 support multiple pdus as described.
 
 That's not entirely unreasonable in itself; my objection is solely to
 the fact that README.developer is completely misleading. In fact, even
 the example dissect_cstr won't work on the tcp dissector, because if you
 set desegment_len=1 the tcp dissector believes that you know what you
 are doing and doesn't let you change your mind later.
 
 Furthermore, 2.7.2 says that you can set desegment_len=-1; that doesn't
 work either, because the tcp dissector expects
 DESEGMENT_ONE_MORE_SEGMENT, which is 0x0fffffff, which is nowhere near -1.
 
 In short, I think the relevant section of README.developer needs a
 rewrite. I attach a patch - comments welcome.

Directory: /trunk/doc/
  Changes    Path                Action
  +51 -49    README.developer    Modified