Wireshark-commits: [Wireshark-commits] rev 18869: /trunk/epan/ /trunk/epan/: packet.c

From: jmayer@xxxxxxxxxxxxx
Date: Thu, 10 Aug 2006 10:09:31 GMT

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=18869

User: jmayer
Date: 2006/08/10 10:09 AM

Log:
 Neil Piercy:
 
 I've just had a bug in one of our private dissectors which meant
 that the handle passed to call_dissector was null. This seemed to give
 varying behavior - on some Windows installations it hit wireshark's
 in-built exception handling, and displayed that the dissector had an
 error (correct), but on some installations it just crashed wireshark
 (not helpful). I _think_ the difference was whether MSVC was installed
 or not, but on a sample of only 3 machines.
 
 Should call_dissector include explicit null handle checks, and if so,
 should it:-
 
 a) g_assert - the simple patch attached
 b) fallback to doing a data decode (as disabled protocols do)
 c) try to invoke the wireshark exception handling for the packet
 
 Or is the correct answer none of the above - the exception handler
 should already cope ?

Directory: /trunk/epan/
  Changes    Path          Action
  +1 -0      packet.c      Modified