Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 8293] OSITP: Incorrect TP4 checksum calculation (ATN exten

Date: Fri, 15 Feb 2013 17:16:25 +0000

changed bug 8293

What Removed Added
Status UNCONFIRMED INCOMPLETE
CC   [email protected]
Ever confirmed   1

Comment # 2 on bug 8293 from
Hi there, thanks for the patch. It looks alright but the indentation makes it a
bit hard to follow. The existing code in packet-ositp.c uses 2-space
indentation, so I'd appreciate it if you would use the same for consistency's
sake.

Also, you imply changes in packet-osi.c and packet-osi.h, but the attached
patch only has changes in packet-ositp.c. Did you miss part of the patch?

Evan


You are receiving this mail because:
  • You are watching all bug changes.