Comment # 17
on bug 8313
from Evan Huus
(In reply to comment #16)
> (In reply to comment #15)
> > Comment on attachment 10017 [details]
> > smb dissector 15.02 (updated)
> >
> > Not sure if it was fix-encodings-args.pl, but the patch now fails
> > checkAPIs.pl because of the insertion of ENC_BIG_ENDIAN into
> > proto_tree_add_bytes_format/proto_tree_add_bytes.
>
> Yes, sorry, I should have caught that (it's been hanging around for a few
> iterations of the patch now). Calls to proto_tree_add_bytes and
> proto_tree_add_bytes_format are specifically for cases where the bytes in
> question are
[BUGZILLA FAIL]
not in the packet. Those calls don't take an encoding argument at all - that
argument should be a pointer to the generated bytes. Since I believe the
intention is to point to bytes that are in the packet itself, you should just
be able to replace those calls with generic proto_tree_add_item calls. These
calls will take an encoding arg, but it is find to leave it as ENC_NA since raw
bytes don't have an endianness.
You are receiving this mail because:
- You are watching all bug changes.
