Evan Huus
changed
bug 8287
| What |
Removed |
Added |
| Status |
IN_PROGRESS
|
INCOMPLETE
|
Comment # 26
on bug 8287
from Evan Huus
(In reply to comment #25)
> Created attachment 10010 [details]
> add links, timespan and number to HTTP dissector
>
> new version using a double linked list and direct lookup via
> p_get_proto_data().
That looks really nice. I'm a bit confused about your use of DISSECTOR_ASSERT
though:
- You shouldn't have to assert (pinfo->fd->num > 0), as that should absolutely
never happen (and it's a Wireshark bug, not a dissector bug, if it does). Were
you seeing cases where these asserts were needed?
- Your assertion that (! conv_data->req_res_tail) is dead, since it's in an
if-statement which guarantees that it succeeds. Likewise with your assertion of
(req_res->prev->next == req_res). It's not as obvious to show, but I believe
the preceeding code also guarantees that it must succeed?
As it stands I'm ready to check this in (pending clarification on the
assertions).
Thanks,
Evan
You are receiving this mail because:
- You are watching all bug changes.
